[libvirt] [PATCH 2/4] hvsupport: drop XML::XPath

[John Ferlan]

On 06/29/2016 02:40 AM, Ján Tomko wrote:
> Doing an XPath query for every single 'function' element in the
> file is inefficient.
> 
> Since the XML file is generated by another of our build scripts
> (apibuild.py, using Python's standard 'output.write' XML library),
> just find the function name->file mapping by a regex upfront.
> ---
>  bootstrap.conf    |  1 -
>  docs/hvsupport.pl | 30 +++++++++++++++++++++++++-----
>  2 files changed, 25 insertions(+), 6 deletions(-)
> 

I know less than zero about what XML::XPath did, but I got no errors
during my test build.

Might be nice to put a word or three in the parseAPIXML to describe
what's being done. I don't find the code entirely self documenting. As
near as I could tell you're searching the output XML files for
"<function name='" and picking off the function name to be searched
elsewhere (the syms files?) to ensure the function has been exported
properly...

Consider this a weak ACK.

John