[libvirt] [PATCH] Changes to support Veritas HyperScale (VxHS) block device protocol with qemu-kvm.

[Daniel P. Berrange]

On Tue, Jul 19, 2016 at 12:28:45AM +0000, Ashish Mittal wrote:
> From 9036f749f12d3bf4bf08e7e55b6d98109dd5e5c0 Mon Sep 17 00:00:00 2001
> From: Ashish Mittal <ashish.mittal at veritas.com>
> Date: Mon, 18 Jul 2016 16:21:37 -0700
> Subject: [PATCH] Changes to support Veritas HyperScale (VxHS) block device protocol with qemu-kvm.
> 
> Changes to support Veritas HyperScale (VxHS) block device protocol with qemu-kvm.

Where is the corresponding QEMU patch for this block device protocol ?
Unless I've missed it, I've not seen it on qemu-devel yet.

As mentioned on the previous review, I really very much doubt the
syntax you're showing here is going to be accepted by QEMU:

> +-drive file=vxhs://192.168.0.1:9999/%7Beb90327c-8302-4725-9e1b-4e85ed4dc251%7D\
> +vxhs://172.172.17.56:9999/%7Beb90327c-8302-4725-9e1b-4e85ed4dc251%7D,\
> +format=raw,if=none,id=drive-virtio-disk0,cache=none \

I really expect you will have to create a proper QAPI schema for expressing
the block device configuration and *not* use the URI format, since the
latter has fallen out of favour with QEMU maintainers.

There's honestly not a much point in reviewing this libvirt code until
there is some certainty around the QEMU design, because it'll cause
significant change to the code in libvirt for formatting the command
line.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|