[libvirt] [PATCH 0/7] Error path cleanup for hotplug and one function move/rename
jferlan at redhat.com
Tue Jul 19 11:21:39 UTC 2016
On 07/19/2016 06:40 AM, Ján Tomko wrote:
> On Fri, Jul 15, 2016 at 07:50:20AM -0400, John Ferlan wrote:
>> During review of the LUKS series:
>> it was noted that the error paths should use bools rather than goto
>> type labels. So this series does that for a few of the affect APIs.
>> also changes to qemuDomainAttachMemory since it seems it wasn't properly
>> handling 'props' at least w/r/t how qemuDomainAttachRNGDevice would clean
>> things up.
>> Finally - another part of the review noted that the qemu command line
>> comma escaping could be made more available since the storage driver
>> would potentially need it to build the qemuimg command line. So I moved
>> to virqemu and renamed.
>> John Ferlan (7):
>> qemu: Alter error path cleanup for qemuDomainAttachHostSCSIDevice
>> qemu: Alter error path cleanup for qemuDomainAttachVirtioDiskDevice
>> qemu: Alter error path cleanup for qemuDomainAttachSCSIDisk
>> qemu: Alter error path cleanup for qemuDomainAttachChrDevice
>> qemu: Alter error path cleanup for qemuDomainAttachRNGDevice
>> qemu: Alter error path cleanup for qemuDomainAttachMemory
>> qemu: Move and rename qemuBufferEscapeComma
>> src/libvirt_private.syms | 1 +
>> src/qemu/qemu_command.c | 33 +++-------
>> src/qemu/qemu_hotplug.c | 163
>> src/util/virqemu.c | 15 +++++
>> src/util/virqemu.h | 2 +
>> 5 files changed, 122 insertions(+), 92 deletions(-)
> ACK series, regardless of the suggestions.
I altered the bool's to use shorter names, used exit_monitor, and moved
the qemuDomainObjExitMonitor outside the orig_err save for each.
Removed the save error for the qemuDomainAttachSCSIDisk cleanup
(although I have other code which will replace it with the drive delete
Series now pushed - thanks!
More information about the libvir-list