[libvirt] [PATCH 4/5] admin: rpc: virnetserver: Fix updating of the client limits

Erik Skultety eskultet at redhat.com
Wed Jul 20 10:53:17 UTC 2016


Commit 2737aaaf changed our policy for accepting new clients in a way, that
instead of accepting new clients only to disconnect them immediately because
that would overcommit the limit we temporarily disable polling for the
dedicated file descriptor, so any new connection will queue on the socket.
Commit 8b1f0469 then added the possibility to change the limits during runtime
but it didn't re-enable polling for the previously disabled file descriptor,
thus any new connection would still continue to queue on the socket. This patch
forces an update of the services each time the limits were changed in some way.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1357776

Signed-off-by: Erik Skultety <eskultet at redhat.com>
---
 src/rpc/virnetserver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index c5caef3..5b6bc4a 100644
--- a/src/rpc/virnetserver.c
+++ b/src/rpc/virnetserver.c
@@ -1071,6 +1071,8 @@ virNetServerSetClientLimits(virNetServerPtr srv,
     if (maxClientsUnauth >= 0)
         srv->nclients_unauth_max = maxClientsUnauth;
 
+    virNetServerCheckLimits(srv);
+
     ret = 0;
  cleanup:
     virObjectUnlock(srv);
-- 
2.5.5




More information about the libvir-list mailing list