[libvirt] [PATCH] lxc: Don't crash by forgetting to ref transient domains

[Daniel P. Berrange]

On Wed, Jul 20, 2016 at 02:56:41PM +0200, Martin Kletzander wrote:
> So commit 306b3a8504 tried mimicking behaviour of commit 540c339a25, but
> added a virObjectRef(vm) only after virDomainObjListAdd() in
> lxcDomainDefineXMLFlags() and not in lxcDomainCreateXMLWithFiles().
> That way undefining a domain that was started with different XML than
> defined will leave the domain object in a state with not enough
> references to then remove it.  Hence any lxcDomainDestroyFlags() called
> afterwards crashes the daemon.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1351057
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  src/lxc/lxc_driver.c | 1 +
>  1 file changed, 1 insertion(+)

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|