[libvirt] [PATCH v2 04/10] Narrow down a parameter

Martin Kletzander mkletzan at redhat.com
Mon Jul 25 09:39:31 UTC 2016


On Sat, Jul 16, 2016 at 02:42:49AM +0200, Tomasz Flendrich wrote:
>This will make splitting up qemuDomainDetachDeviceFlags into two
>functions easier.
>
>---
> src/qemu/qemu_driver.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>index 5dde81f..ce22eff 100644
>--- a/src/qemu/qemu_driver.c
>+++ b/src/qemu/qemu_driver.c
>@@ -7472,9 +7472,8 @@ qemuDomainDetachDeviceControllerLive(virQEMUDriverPtr driver,
> static int
> qemuDomainDetachDeviceLive(virDomainObjPtr vm,
>                            virDomainDeviceDefPtr dev,
>-                           virDomainPtr dom)
>+                           virQEMUDriverPtr driver)
> {
>-    virQEMUDriverPtr driver = dom->conn->privateData;
>     int ret = -1;
>
>     switch ((virDomainDeviceType) dev->type) {
>@@ -8403,7 +8402,7 @@ qemuDomainDetachDeviceFlags(virDomainPtr dom,
>                                          VIR_DOMAIN_DEVICE_ACTION_DETACH) < 0)
>             goto endjob;
>
>-        if ((ret = qemuDomainDetachDeviceLive(vm, dev_copy, dom)) < 0)
>+        if ((ret = qemuDomainDetachDeviceLive(vm, dev_copy, dom->conn->privateData)) < 0)

As mentioned in patch #1, I'd rather see non-void pointer passed here.

>             goto endjob;
>         /*
>          * update domain status forcibly because the domain status may be
>--
>2.7.4
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160725/f2457711/attachment-0001.sig>


More information about the libvir-list mailing list