[libvirt] [PATCH] virconf: Fix config file path construction

Martin Kletzander mkletzan at redhat.com
Wed Jul 27 14:27:40 UTC 2016


On Wed, Jul 27, 2016 at 08:50:42AM +0200, Erik Skultety wrote:
>Since commit c4bdff19, the path to the configuration file has been constructed
>in the following manner:
> - if no config filename was passed to virConfLoadConfigPath, libvirt.conf was
> used as default
> - otherwise the filename was concatenated with
> "<config_dir>/libvirt/libvirt%s%s.conf" which in admin case resulted in
> "libvirt-libvirt-admin.conf.conf". Obviously, this non-existent config led to
> ignoring  all user settings in libvirt-admin.conf. This patch requires the
> config filename to be always provided as an argument with the concatenation
> being simplified.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1357364
>
>Signed-off-by: Erik Skultety <eskultet at redhat.com>
>---
> src/libvirt.c      |  2 +-
> src/util/virconf.c | 12 ++++--------
> 2 files changed, 5 insertions(+), 9 deletions(-)
>

More versatile and nicer.  ACK.  I guess it should've been called with "admin"
instead of the full name.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160727/1dbdc8ed/attachment-0001.sig>


More information about the libvir-list mailing list