[libvirt] [PATCH] conf: Catch invalid memory model earlier
Martin Kletzander
mkletzan at redhat.com
Fri Jul 29 06:40:24 UTC 2016
On Thu, Jul 28, 2016 at 06:28:40PM +0200, Michal Privoznik wrote:
>Consider the following XML snippet:
>
> <memory model=''>
> <target>
> <size unit='KiB'>523264</size>
> <node>0</node>
> </target>
> </memory>
>
>Whats wrong you ask? The @model attribute. This should result in
>an error thrown into users faces during virDomainDefine phase.
>Except it doesn't. The XML validation catches this error, but if
>users chose to ignore that, they will end up with invalid XML.
>Well, they won't be able to start the machine - that's when error
>is produced currently. But it would be nice if we could catch the
>error like this earlier.
>
I wonder why there's "" for MODEL_NONE and why it's even there.
Hoping we will use more models, ACK.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160729/db8f655d/attachment-0001.sig>
More information about the libvir-list
mailing list