[libvirt] [PATCH 2/2] qemu: generate -display none

[Paolo Bonzini]

On 05/07/2016 14:59, Daniel P. Berrange wrote:
> >      if (!def->ngraphics) {
> > -        virCommandAddArg(cmd, "-nographic");
> > +        if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISPLAY)) {
> > +            virCommandAddArg(cmd, "-display");
> > +            virCommandAddArg(cmd, "none");
> > +        } else {
> > +            virCommandAddArg(cmd, "-nographic");
> > +        }
>
> Am I right in thinking that -display none vs -nographic has *no* effect
> on guest machine ABI ? I think we're safe based on my reading of it,
> particularly since we use -nodefaults and -nodefconfig, but want to confirm
> there's no edge case i'm not aware of.

It changes one fw_cfg field from 0 to 1, but only OpenBIOS looks at it
right now.

Paolo