[libvirt] [PATCH 2/4] virsh: Fix variable types in readline generators

Nishith Shah nishithshah.2211 at gmail.com
Fri Jul 8 12:56:03 UTC 2016


Use unsigned int for array indexes and size_t for length variables.

Signed-off-by: Nishith Shah <nishithshah.2211 at gmail.com>
---
 tools/vsh.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/vsh.c b/tools/vsh.c
index dcf99f2..c5d7578 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -2537,7 +2537,8 @@ vshTreePrint(vshControl *ctl, vshTreeLookup lookup, void *opaque,
 static char *
 vshReadlineCommandGenerator(const char *text, int state)
 {
-    static int grp_list_index, cmd_list_index, len;
+    static unsigned int grp_list_index, cmd_list_index;
+    static size_t len;
     const char *name;
     const vshCmdGrp *grp;
     const vshCmdDef *cmds;
@@ -2576,7 +2577,8 @@ vshReadlineCommandGenerator(const char *text, int state)
 static char *
 vshReadlineOptionsGenerator(const char *text, int state)
 {
-    static int list_index, len;
+    static unsigned int list_index;
+    static size_t len;
     static const vshCmdDef *cmd;
     const char *name;
 
-- 
2.7.4




More information about the libvir-list mailing list