[libvirt] [PATCH REPOST 1/3] util: hostcpu: Add virHostCPUGetKVMMaxVCPUs() stub

Andrea Bolognani abologna at redhat.com
Mon Jul 11 09:09:57 UTC 2016


On Sat, 2016-07-09 at 10:33 +0200, Michal Privoznik wrote:
> > +virHostCPUGetKVMMaxVCPUs(void)
> > +{
> > +    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> > +                   _("KVM is not supported on this platform"));
> 
> Don't mean to bikeshed, but I'd  prefer if this were:
> 
> virReportSystemError(ENOSYS, ..);
> 
> I think it's the common patter we use for non-Linux, non-BSD* platform
> stubs. And if you think of it, it really is a property of a system, not
> unsupported config on libvirt level. BTW I know that we are not
> consistent in the error codes. It's one big mess.

Makes sense, and it's indeed a very common pattern throughout
libvirt. I changed it.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list