[libvirt] [PATCH REPOST 2/3] util: hostcpu: Drop obsolete compatibility code
Andrea Bolognani
abologna at redhat.com
Mon Jul 11 09:12:10 UTC 2016
On Sat, 2016-07-09 at 10:33 +0200, Michal Privoznik wrote:
> On 08.07.2016 18:04, Andrea Bolognani wrote:
> > All Linux releases we support (RHEL6 era) include these
> > definitions.
> > ---
> > src/util/virhostcpu.c | 11 -----------
> > 1 file changed, 11 deletions(-)
> >
> > diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
> > index a33932f..8a8bda8 100644
> > --- a/src/util/virhostcpu.c
> > +++ b/src/util/virhostcpu.c
> > @@ -65,17 +65,6 @@ VIR_LOG_INIT("util.hostcpu");
> >
> > #define KVM_DEVICE "/dev/kvm"
> >
> > -/* add definitions missing in older linux/kvm.h */
> > -#ifndef KVMIO
> > -# define KVMIO 0xAE
> > -#endif
> > -#ifndef KVM_CHECK_EXTENSION
> > -# define KVM_CHECK_EXTENSION _IO(KVMIO, 0x03)
> > -#endif
> > -#ifndef KVM_CAP_NR_VCPUS
> > -# define KVM_CAP_NR_VCPUS 9 /* returns max vcpus per vm */
> > -#endif
> > -
> >
> > #if defined(__FreeBSD__) || defined(__APPLE__)
> > static int
> >
>
> ACK.
>
> /me just wonders why we even had that code. These defs where since Avi
> Kivity started merging KVM to kernel. This is 2006 that we're talking here!
Well, before having a stub for the purpose, those defines
were also needed in order to be able to compile on non-Linux
platforms :)
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list