[libvirt] [PATCH] virCommandExec: Report error if execve fails

[Martin Kletzander]

On Mon, Jul 11, 2016 at 05:42:41PM +0200, Martin Kletzander wrote:
>On Mon, Jul 11, 2016 at 04:11:22PM +0200, Michal Privoznik wrote:
>>In an unlikely event of execve() failing, the virCommandExec()
>>function does not report any error, even though checks that are
>>at the beginning of the function are verbose when failing.
>>
>>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>>---
>> src/util/vircommand.c |  7 +++++-
>> tests/commandtest.c   | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 75 insertions(+), 1 deletion(-)
>>
>
>Looks good, but the tests sometimes fails on me with "Child should have
>returned an error".  You might want to investigate that.

Also I get:

tests/commandtest.c:1086:    pid = fork();

When running make syntax-check...

>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160711/6645934f/attachment-0001.sig>