[libvirt] [PATCH] tests: add missed directories in EXTRA_DIST

lhuang lhuang at redhat.com
Tue Jul 12 10:07:29 UTC 2016



On 07/12/2016 05:41 PM, Martin Kletzander wrote:
> On Tue, Jul 12, 2016 at 04:28:22PM +0800, Luyao Huang wrote:
>> In commit ec5dcf2a and b0b4a35c, we have moved some xml to
>> new directories, but forget fix the Makefile. Add 2 directories
>> in EXTRA_DIST to fix broken vpath build.
>>
>> Signed-off-by: Luyao Huang <lhuang at redhat.com>
>> ---
>> tests/Makefile.am | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> index fb2380d..010e348 100644
>> --- a/tests/Makefile.am
>> +++ b/tests/Makefile.am
>> @@ -122,6 +122,8 @@ EXTRA_DIST =        \
>>     qemucaps2xmldata \
>>     qemuhelpdata \
>>     qemuhotplugtestdata \
>
> This ^^ should be removed as well, there are two unused files in it only
> that I mistakenly created.  I'll add this to the commit, adjust the
> commit message and push it in a while.  Thanks for noticing.
>

Oh, you are right, i didn't deep check these code when i wrote this patch.

Thanks a lot for your review.

Have a nice day !
Luyao

>> +    qemuhotplugtestdevices \
>> +    qemuhotplugtestdomains \
>>     qemumonitorjsondata \
>>     qemuxml2argvdata \
>>     qemuxml2xmloutdata \
>> -- 
>> 1.8.3.1
>>
>> -- 
>> libvir-list mailing list
>> libvir-list at redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list




More information about the libvir-list mailing list