[libvirt] [PATCH v4 1/7] tests: Adjust LUKS tests to use 'volume' secret type

Ján Tomko jtomko at redhat.com
Thu Jul 14 11:47:46 UTC 2016


On Mon, Jul 11, 2016 at 02:07:52PM -0400, John Ferlan wrote:
>Commit id's '9bbf0d7e6' and '2552fec24' added some XML parsing tests
>for a LUKS volume to use a 'passphrase' secret format. After commit,
>this was deemed to be incorrect, so covert the various tests to use
>the volume usage format where the 'usage' is the path to the volume
>rather than a user defined name string.
>
>Also, removed the qemuxml2argv-luks-disk-cipher.xml since it was
>just a duplicate of qemuxml2argv-luks-disks.xml.
>
>Signed-off-by: John Ferlan <jferlan at redhat.com>
>---
> .../qemuxml2argv-luks-disk-cipher.xml              | 45 ----------------------
> tests/qemuxml2argvdata/qemuxml2argv-luks-disks.xml |  2 +-
> .../qemuxml2xmlout-luks-disk-cipher.xml            |  1 -
> tests/qemuxml2xmltest.c                            |  1 -
> tests/storagevolxml2xmlin/vol-luks-cipher.xml      |  2 +-
> tests/storagevolxml2xmlin/vol-luks.xml             |  2 +-
> tests/storagevolxml2xmlout/vol-luks-cipher.xml     |  2 +-
> tests/storagevolxml2xmlout/vol-luks.xml            |  2 +-
> 8 files changed, 5 insertions(+), 52 deletions(-)
> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-luks-disk-cipher.xml
> delete mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-luks-disk-cipher.xml
>

ACK

Jan




More information about the libvir-list mailing list