[libvirt] [PATCH] security: compilation error due to wrong parameter for vah_add_path().
Peter Krempa
pkrempa at redhat.com
Tue Jul 19 07:03:55 UTC 2016
On Mon, Jul 18, 2016 at 22:09:20 -0300, Julio Faracco wrote:
> The commit da665fbd introduced virStorageSourcePtr inside the structure
> _virDomainFSDef. This is causing an error when libvirt is being compiled.
>
> make[3]: Entering directory `/media/julio/8d65c59c-6ade-4740-9cdc-38016a4cb8ae
> /home/julio/Desktop/virt/libvirt/src'
> CC security/virt_aa_helper-virt-aa-helper.o
> security/virt-aa-helper.c: In function 'get_files':
> security/virt-aa-helper.c:1087:13: error: passing argument 2 of 'vah_add_path'
> from incompatible pointer type [-Werror]
> if (vah_add_path(&buf, fs->src, "rw", true) != 0)
> ^
> security/virt-aa-helper.c:732:1: note: expected 'const char *' but argument is
> of type 'virStorageSourcePtr'
> vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool
> recursive)
> ^
> cc1: all warnings being treated as errors
>
> Adding the attribute "path" from virStorageSourcePtr fixes this issue.
>
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
> src/security/virt-aa-helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK and I'll push this in a while.
Peter
More information about the libvir-list
mailing list