[libvirt] [PATCH 5/9] vsh: Properly initialize res

Ján Tomko jtomko at redhat.com
Tue Jul 19 11:16:15 UTC 2016


On Mon, Jul 18, 2016 at 03:06:56PM -0400, John Ferlan wrote:
>The 'res' variable was only being initialized to NULL in the
>if (!state) path; however, that path never used res and evenutally
>res is assigned one of two results based on a pair of if then else if
>conditions. If for some reason neither of those paths was taken and
>the (!state) path wasn't take, then 'res' would be indeterminate.
>
>Found by Coverity, probably a false positive based on code paths, but
>better safe than sorry for the future.

Yes, it seems the function could be made more understandable, but this
patch is an improvement.

ACK to patches 1 to 5.

Jan




More information about the libvir-list mailing list