[libvirt] [PATCHv2 3/3] hvsupport: skip non-matching lines early

Ján Tomko jtomko at redhat.com
Tue Jul 19 16:55:54 UTC 2016


Most of the lines we look at are not going to match one of the
driver types contained in $groups_regex.

Move on to the next line if it does not contain any of them early.
This speeds up the script execution by 50%, since this simple regex
does not have any capture groups.
---
 docs/hvsupport.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/docs/hvsupport.pl b/docs/hvsupport.pl
index fca83ca..2ead2cf 100755
--- a/docs/hvsupport.pl
+++ b/docs/hvsupport.pl
@@ -212,6 +212,9 @@ foreach my $src (@srcs) {
     my $impl;
     while (defined($line = <FILE>)) {
         if (!$ingrp) {
+            # skip non-matching lines early to save time
+            next if not $line =~ /$groups_regex/;
+
             if ($line =~ /^\s*(?:static\s+)?($groups_regex)\s+(\w+)\s*=\s*{/ ||
                 $line =~ /^\s*(?:static\s+)?($groups_regex)\s+NAME\(\w+\)\s*=\s*{/) {
                 $ingrp = $1;
-- 
2.7.3




More information about the libvir-list mailing list