[libvirt] [PATCHv2 1/3] hvsupport: use a regex instead of XML::XPath

Peter Krempa pkrempa at redhat.com
Wed Jul 20 08:07:34 UTC 2016


On Tue, Jul 19, 2016 at 18:55:52 +0200, Ján Tomko wrote:
> When generating the hvsupport.html.in file, we parse the -api.xml
> files generated by apibuild.py to know in which HTML file the API
> function is.
> 
> Doing an XPath query for every single 'function' element in the
> file is inefficient.
> 
> Since the XML file is generated by another of our build scripts
> (apibuild.py, using Python's standard 'output.write' XML library),
> just find the function name->file mapping by a regex upfront.
> 
> Also add a note about this next to the line that generates it
> in apibuild.py and do not check if XML::XPath is installed in
> bootstrap since we no longer use it.
> ---
>  bootstrap.conf    |  1 -
>  docs/apibuild.py  |  1 +
>  docs/hvsupport.pl | 33 ++++++++++++++++++++++++++++-----
>  3 files changed, 29 insertions(+), 6 deletions(-)

ACK




More information about the libvir-list mailing list