[libvirt] [PATCH v2 00/10] Test persistent device attachment

[Martin Kletzander]

On Sat, Jul 16, 2016 at 02:42:45AM +0200, Tomasz Flendrich wrote:
>Changes in v2:
>* rebased
>
>This patch requires another one, otherwise a small conflict appears:
>https://www.redhat.com/archives/libvir-list/2016-July/msg00402.html
>
>In qemu_driver.c, two functions were split to have less responsibility.
>They were also modified so that they could be used in qemuhotplugtest.
>Now instead of running different functions to attach different device
>types, a generic function is run. Hopefully this will result in more
>device types tested in the future.
>
>Suggestions on how to name these two new functions are very welcome.
>
>In the future, if one uses the following command:
>virsh attach-device --live --config
>the new device will have the same address assigned in both live
>and config domain. To make sure that everything will work properly
>after making these changes, I reworked qemuhotplug.c to work with
>attaching devices to persistent domains.
>
>So far, there is only one test for persistent attachment. I will
>add more testcases as soon as I hear some feedback on these changes.
>qemuhotplugtest.c should first be modified anyway, so that the three
>xmls's filenames (basis domain xml, device xml, expected xml) are stated
>explicitly instead of being calculated. This will allow for more
>flexibility in testing and less xml files duplicates.
>
>

ACK to patches 01-05, I'll push those in a while.  I fixed up the nits
pointed out in the review for some of those.  Also reworded some subject
lines to be a little more descriptive.  The rest looks fine, it just
needs a tiny bit more of modification so I would rather make it go
through review again so that at least two pairs of eyes see it.

Thanks a lot for your patience,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160725/7ebcde47/attachment-0001.sig>