[libvirt] [PATCH v2 06/10] qemu: remove ccwaddrs caching

Martin Kletzander mkletzan at redhat.com
Mon Jul 25 15:15:14 UTC 2016


On Sat, Jul 23, 2016 at 03:47:11AM +0200, Tomasz Flendrich wrote:
>Dropping the caching of ccw address set.
>The cached set is not required anymore, because the set is now being
>recalculated from the domain definition on demand, so the cache
>can be deleted.
>---
> src/qemu/qemu_domain.c         |  1 -
> src/qemu/qemu_domain.h         |  1 -
> src/qemu/qemu_domain_address.c | 23 +++--------------------
> 3 files changed, 3 insertions(+), 22 deletions(-)
>
>diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
>index b23790f..66ab70e 100644
>--- a/src/qemu/qemu_domain_address.c
>+++ b/src/qemu/qemu_domain_address.c
>@@ -1804,13 +1793,7 @@ qemuDomainReleaseDeviceAddress(virDomainObjPtr vm,
>     if (!devstr)
>         devstr = info->alias;
>
>-    if (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW &&
>-        qemuDomainMachineIsS390CCW(vm->def) &&
>-        virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_CCW) &&
>-        virDomainCCWAddressReleaseAddr(priv->ccwaddrs, info) < 0)
>-        VIR_WARN("Unable to release CCW address on %s",
>-                 NULLSTR(devstr));
>-    else if (virDeviceInfoPCIAddressPresent(info) &&
>+    if (virDeviceInfoPCIAddressPresent(info) &&
>              virDomainPCIAddressReleaseSlot(priv->pciaddrs,
>                                             &info->addr.pci) < 0)

Indentation's off.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160725/59b8a9cc/attachment-0001.sig>


More information about the libvir-list mailing list