[libvirt] [PATCH v2 10/10] Add a persistent attachment testcase

Tomasz Flendrich t.flendrich at gmail.com
Tue Jul 26 23:33:06 UTC 2016


>
> diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-base-config.xml
>> b/tests/qemuhotplugtestdomains/qemuhotplug-base-config.xml
>> new file mode 100644
>> index 0000000..20ad0a5
>> --- /dev/null
>> +++ b/tests/qemuhotplugtestdomains/qemuhotplug-base-config.xml
>>
>
> I don't think we need two base files, the live one should parse cleanly
> as config one.  Although having this one makes it way easier to just see
> the diff of base and base+something to see the difference.  OK, let's
> keep it here :)
>

I agree that a live one would work in DO_TEST_ATTACH. We need the one
with "-config" because in DO_TEST_DETACH it is used as the expected xml.

Tomasz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160727/1c47b8eb/attachment-0001.htm>


More information about the libvir-list mailing list