[libvirt] [PATCH v3 0/6] Test persistent device attachment

Tomasz Flendrich t.flendrich at gmail.com
Thu Jul 28 19:53:55 UTC 2016


Changes in v3:
* fewer patches, because part of v2 was ACK'd
* two old commits, 08/10 and 09/10, are now one commit
* qemuDomainUpdateDeviceFlags is now also split, creating a new function
  qemuDomainUpdateDeviceLiveAndConfig(). This function is now used in
  qemuhotplugtest.c.
* qemuDomainAttachDeviceLiveAndConfig, qemuDomainDetachDeviceLiveAndConfig
  and qemuDomainUpdateDeviceLiveAndConfig are now in a new file:
  qemu_driverpriv.h
* variable "target" is renamed to "impact" and its type is changed
* testQemuHotplugCheckResult() now takes "impact" as a parameter to determine
  whether to test the ->def or ->newDef
* def->id is no longer set when handling a persistent domain
* split DO_TEST_ATTACH (and other macros) to DO_TEST_ATTACH_LIVE and
  DO_TEST_ATTACH_CONFIG instead of taking a parameter
* fixed indentation
* "<source mode='bind'/>" is removed from one xml
* a three year old testcase for updating a disk device was modified
  a little bit to make it finally execute and test something

Link to v2: https://www.redhat.com/archives/libvir-list/2016-July/msg00595.html

Tomasz Flendrich (6):
  Split qemuDomainUpdateDeviceFlags in two
  Make qemu attach/detach functions public
  Make qemuhotplugtest work with persistent domains
  qemuhotplug: Use a more generic function to update devices
  qemuhotplugtest: add testcase to update a disk device
  qemuhotplugtest: add a persistent attachment testcase

 src/qemu/qemu_driver.c                             | 117 +++---
 src/qemu/qemu_driverpriv.h                         |  47 +++
 tests/qemuhotplugtest.c                            | 433 ++++++++++++---------
 .../qemuhotplug-disk-cdrom-nochange.xml            |   2 +-
 .../qemuhotplug-qemu-agent.xml                     |   1 -
 .../qemuhotplug-base-config+qemu-agent+config.xml  |  44 +++
 .../qemuhotplug-base-config.xml                    |  40 ++
 .../qemuhotplug-disk-cdrom.xml                     |   2 +-
 8 files changed, 454 insertions(+), 232 deletions(-)
 create mode 100644 src/qemu/qemu_driverpriv.h
 create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-config+qemu-agent+config.xml
 create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-config.xml

-- 
1.9.1




More information about the libvir-list mailing list