[libvirt] [PATCH 00/13] Move functions from qemu_domain_address.c to domain_addr.c

[Daniel P. Berrange]

On Thu, Jul 28, 2016 at 07:00:40PM -0400, Laine Stump wrote:
> On 07/19/2016 08:07 PM, Tomasz Flendrich wrote:
> > This series depends on another one:
> > https://www.redhat.com/archives/libvir-list/2016-July/msg00696.html
> > 
> > Because the address sets are no longer cached, it's possible to move
> > functions that don't depend on qemu anymore from qemu_domain_address.c
> > to domain_addr.c. I did that with virtioSerial and PCI.
> > 
> > To make some functions not dependent on qemuCaps, their parameters
> > were changed to booleans. These changes are in [PATCH 02/13].
> > 
> > If you are satisfied with this approach, I can do the same with
> > the rest of the functions or just some of them.
> 
> The problem is that many/most these functions are by definition
> qemu-specific - only the qemu driver has any concept of a Q35 machinetype or
> a PIIX3 controller (actually that function should probably have used
> "i440fx" instead of PIIX3) or an aarch64 "virt" machinetype, or any use for
> a "busNr" etc etc. So moving them from qemu into conf is busy-work that is
> counter-productive.

Agreed, I would consider it to be mandatary to separate the general address
handling logic (which could be in conf) from the logic that assigns addresses
for specific QEMU machine types (which should always remain in the QEMU drive
dir).


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|