[libvirt] [PATCH] conf: always format os.bootloaderArgs if set

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Jun 6 04:43:46 UTC 2016


  Martin Kletzander wrote:

> On Tue, May 31, 2016 at 08:06:06PM +0200, Fabian Freyer wrote:
> >At the moment the bootloader arguments never get formatted if the
> >bootloader is unset. However, in cases where the bootloader defaults to
> >a default value when unset, specifying bootloader arguments does make
> >sense.
> 
> Please wrap long lines.  If the bootloader defaults to something, it
> should be set to that default.  So NACK to this approach (unless I
> missed something).

In other words, if we don't have bootloader defined and decide to go
with bhyveload, it means that we need to update XML accordingly?

This sounds like a reasonable thing to do, but probably we should agree
on the UEFI boot case first. As it does not require the 2-step boot
process with external loader, we should differentiate this case in order
not to see bootloader when it's not needed.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160606/60223d07/attachment-0001.sig>


More information about the libvir-list mailing list