[libvirt] [PATCH v2] systemd: directly notify systemd instead of using sd_notify

Andrea Bolognani abologna at redhat.com
Tue Jun 7 07:19:03 UTC 2016


On Mon, 2016-06-06 at 16:21 +0100, Daniel P. Berrange wrote:
> The sd_notify method is used to tell systemd when libvirtd
> has finished starting up. All it does is send a datagram
> containing the string parameter to systemd on a UNIX socket
> named in the NOTIFY_SOCKET environment variable. Rather than
> pulling in the systemd libraries for this, just code the
> notification directly in libvirt as this is a stable ABI
> from systemd's POV which explicitly allows independant
> implementations:
> 
> See "Reimplementable Independently" column in the
> "$NOTIFY_SOCKET Daemon Notifications" row:
> 
> https://www.freedesktop.org/wiki/Software/systemd/InterfacePortabilityAndStabilityChart/
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  configure.ac              |  2 --
>  libvirt.spec.in           | 12 -----------
>  m4/virt-systemd-daemon.m4 | 34 ------------------------------
>  src/Makefile.am           |  4 ++--
>  src/util/virsystemd.c     | 53 ++++++++++++++++++++++++++++++++++++++++++-----
>  5 files changed, 50 insertions(+), 55 deletions(-)
>  delete mode 100644 m4/virt-systemd-daemon.m4

As Cole noted in response to my previous attempt, this

  Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1314881

Please include said information in the commit message
before pushing.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list