[libvirt] [PATCH] virschematest: Access the right directory containing XMLs

Michal Privoznik mprivozn at redhat.com
Wed Jun 8 09:09:08 UTC 2016


So the story goes like this. The testSchemaDirs() function is
called with: a) the schema file, b) list of the directories that
contains XMLs documents that should be checked against the schema
file from a). However, the directories in the list are really
just their names and it's up to testSchemaDirs to construct the
absolute path and call testSchemaDir() which then does the actual
validation. The absolute path is constructed, but never actually
used (maybe due to a typo). Thus a VPATH build is broken.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tests/virschematest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/virschematest.c b/tests/virschematest.c
index f4d41bd..c173037 100644
--- a/tests/virschematest.c
+++ b/tests/virschematest.c
@@ -140,7 +140,7 @@ testSchemaDirs(const char *schema, ...)
             ret = -1;
             goto cleanup;
         }
-        if (testSchemaDir(schema, validator, dir) < 0)
+        if (testSchemaDir(schema, validator, dir_path) < 0)
             ret = -1;
         VIR_FREE(dir_path);
     }
-- 
2.8.3




More information about the libvir-list mailing list