[libvirt] [PATCH] virsh-domain: fix memory leak in cmdDomDisplay

Pavel Hrdina phrdina at redhat.com
Thu Jun 9 07:16:53 UTC 2016


Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 tools/virsh-domain.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 6f8edbb..11116a9 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10637,8 +10637,10 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd)
                  * fails, if there is no listen_addr we will print "localhost". */
                 VIR_FREE(listen_addr);
 
-                if (uri && VIR_STRDUP(listen_addr, uri->server) < 0)
-                    goto cleanup;
+                if (uri) {
+                    listen_addr = vshStrdup(ctl, uri->server);
+                    virURIFree(uri);
+                }
             }
         }
 
-- 
2.8.3




More information about the libvir-list mailing list