[libvirt] [PATCH 1/6] Introduce storage lifecycle event APIs

[Cole Robinson]

On 06/09/2016 05:43 PM, Cole Robinson wrote:
> On 06/09/2016 02:25 PM, Jovanka Gulicoska wrote:
>> virConnectStoragePoolEventRegisterAny:
>> Adds a callback to receive notifications of storage pool events
>> occurring on a storage pool. Returns a positive integer identifier for
>> the callback
>>
>> virConnectStoragePoolEventDeregisterAny:
>> Removes an event callback
>>
>> virConnectStoragePoolEventGenericCallback:
>> A generic storage pool event callback handler, for use with
>> virStoragePoolEventRegisterAny().
>>
>> VIR_STORAGE_POOL_EVENT_CALLBACK:
>> Used to cast the event specific callback into the generic one
>> for use for virConnectionStoragePoolEventRegisterAny()
>>
>> virStoragePoolEventID:
>> An enumeration of supported eventIDs for virStoragePoolEventRegisterAny()
>>
>> virStoragePoolEventLifecycleType (VIR_STORAGE_POOL_EVENT_ID_LIFECYCLE):
>> emitting during storage pool lifecycle events
>>
>> virConnectStoragePoolEventLifecycleCallback:
>> This callback occurs when pool is started, stopped or refreshed. Used
>> when registering an event of type VIR_STORAGE_POOL_EVENT_ID_LIFECYCLE with
>> virStoragePoolEvenTrgisterAny()

Meant to comment on the commit message. Since the code has the actual
documentation, and this is just following a familiar pattern, I think you can
just list the main bits being added:

virConnectStoragePoolEventRegisterAny
virConnectStoragePoolEventDeregisterAny
virStoragePoolEventLifecycleType which has events STARTED, STOPPED, DEFINED,
UNDEFINED, and REFRESHED

and maybe a small bit of intro text that this is just the API entry points

Thanks,
Cole