[libvirt] [PATCH 1/9] qemuDomainDetachDeviceConfig: make idx type of ssize_t

[Peter Krempa]

On Thu, Jun 09, 2016 at 17:02:36 +0200, Michal Privoznik wrote:
> The variable is used to hold the index to the device array we are
> trying to remove. All the functions that set it are expecting it
> to be type of ssize_t instead of int.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index e70d3ce..d7b65f1 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -7951,7 +7951,7 @@ qemuDomainDetachDeviceConfig(virDomainDefPtr vmdef,
>      virDomainControllerDefPtr cont, det_cont;
>      virDomainChrDefPtr chr;
>      virDomainFSDefPtr fs;
> -    int idx;
> +    ssize_t idx;

A random sample of the "vir*FindBy*" return an integer that is fed to
idx and then the functions removing that take a size_t. Use of int here
is consistent with the return value of those functions.

Are you planing on fixing those too?