[libvirt] [PATCH v2 1/6] Introduce storage lifecycle event APIs

[Peter Krempa]

On Mon, Jun 13, 2016 at 18:38:38 +0200, Jovanka Gulicoska wrote:
> Storage pool lifecycle event API entry points for registering and deregistering
> storage pool events, as well as types of events associated with storage pools.
> These entry points will be used for implementing asynchronous lifecycle events.
> 
> Storage pool API:
> virConnectStoragePoolEventRegisterAny
> virConnectStoragePoolEventDeregisterAny
> virStoragePoolEventLifecycleType which has events STARTED, STOPPED, DEFINED,
> UNDEFINED, and REFRESHED
> ---
>  include/libvirt/libvirt-storage.h |  94 ++++++++++++++++++++++++++++
>  src/datatypes.h                   |  13 ++++
>  src/driver-storage.h              |  14 +++++
>  src/libvirt-storage.c             | 125 ++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms           |   7 +++
>  5 files changed, 253 insertions(+)

[...]

> diff --git a/src/datatypes.h b/src/datatypes.h
> index 8ccc7b0..638bd23 100644
> --- a/src/datatypes.h
> +++ b/src/datatypes.h
> @@ -143,6 +143,19 @@ extern virClassPtr virAdmClientClass;
>          }                                                               \
>      } while (0)
>  
> +# define virCheckStoragePoolGoto(obj, label)                            \
> +    do {                                                                \
> +        virStoragePoolPtr _pool= (obj);                                \

Broken alignment

> +        if (!virObjectIsClass(_pool, virStoragePoolClass) ||            \
> +            !virObjectIsClass(_pool->conn, virConnectClass)) {          \
> +            virReportErrorHelper(VIR_FROM_STORAGE,                      \
> +                                 VIR_ERR_INVALID_STORAGE_POOL,          \
> +                                 __FILE__, __FUNCTION__, __LINE__,      \
> +                                 __FUNCTION__);                         \
> +            goto label;                                                 \
> +        }                                                               \
> +    } while (0)
> +
>  # define virCheckStorageVolReturn(obj, retval)                          \
>      do {                                                                \
>          virStorageVolPtr _vol = (obj);                                  \