[libvirt] [PATCH] virHostCPUGetInfo: Fix build on non-Unix like systems

Michal Privoznik mprivozn at redhat.com
Tue Jun 14 15:02:04 UTC 2016


This function is plenty of ifdefs providing implementations for
Linux, *BSD and OS-X. However, if we are being build for any
other architecture, all that's left behind by preprocessor is
just a error reporting call and return of -1. In that case,
passed arguments are unused:

../../src/util/virhostcpu.c: In function 'virHostCPUGetInfo':
../../src/util/virhostcpu.c:966:33: error: unused parameter 'cpus' [-Werror=unused-parameter]
                   unsigned int *cpus,
                                 ^~~~

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/virhostcpu.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
index 00c09cd..a481be0 100644
--- a/src/util/virhostcpu.c
+++ b/src/util/virhostcpu.c
@@ -963,12 +963,12 @@ virHostCPUParseMapLinux(int max_cpuid, const char *path)
 
 int
 virHostCPUGetInfo(virArch hostarch ATTRIBUTE_UNUSED,
-                  unsigned int *cpus,
-                  unsigned int *mhz,
-                  unsigned int *nodes,
-                  unsigned int *sockets,
-                  unsigned int *cores,
-                  unsigned int *threads)
+                  unsigned int *cpus ATTRIBUTE_UNUSED,
+                  unsigned int *mhz ATTRIBUTE_UNUSED,
+                  unsigned int *nodes ATTRIBUTE_UNUSED,
+                  unsigned int *sockets ATTRIBUTE_UNUSED,
+                  unsigned int *cores ATTRIBUTE_UNUSED,
+                  unsigned int *threads ATTRIBUTE_UNUSED)
 {
 #ifdef __linux__
     int ret = -1;
-- 
2.8.4




More information about the libvir-list mailing list