[libvirt] [PATCH 0/9] syntax-check: make spacing check faster

Ján Tomko jtomko at redhat.com
Wed Jun 15 10:06:49 UTC 2016


Simplify some regexes to increase coverage and speed up the execution.

Reduces (git ls-files "*.c" | xargs build-aux/bracket-spacing.pl) by
half a second (from 1.9s to 1.33s), the effect on complete syntax-check
is only ~150 ms.

Ján Tomko (9):
  vbox: reformat multi-line error reports
  maint: remove whitespace from closing parentheses
  Rename virAssertCmpInt to testAssertEq
  Rename bracket-spacing.pl to check-spacing.pl
  check-spacing: rewrite whitespace check before (semi)colon
  check-spacing: rewrite regex for checking the closing parenthesis
  check-spacing: simplify keyword spacing check
  check-spacing: remove virAssertCmpInt exception
  check-spacing: use non-capturing groups

 build-aux/bracket-spacing.pl  | 204 ------------------------------------------
 build-aux/check-spacing.pl    | 204 ++++++++++++++++++++++++++++++++++++++++++
 cfg.mk                        |   6 +-
 src/qemu/qemu_command.c       |   3 +-
 src/vbox/vbox_common.c        |   8 +-
 src/vbox/vbox_snapshot_conf.c |  68 +++++++-------
 src/vz/vz_driver.c            |   3 +-
 src/vz/vz_sdk.c               |   3 +-
 tests/viratomictest.c         |  52 +++++------
 9 files changed, 274 insertions(+), 277 deletions(-)
 delete mode 100755 build-aux/bracket-spacing.pl
 create mode 100755 build-aux/check-spacing.pl

-- 
2.7.3




More information about the libvir-list mailing list