[libvirt] [PATCH python v4 4/7] remote: implement storage lifecycle event APIs
Cole Robinson
crobinso at redhat.com
Thu Jun 16 16:22:42 UTC 2016
Something weird happened with the series titles, they have 'python' in the
name! Did you trigger send-email from the libvirt-python.git directory, or
maybe you edited .git/config in the wrong repo?
Anyways, I've pushed patches 1-6 with the following changes to this patch:
On 06/16/2016 04:08 AM, Jovanka Gulicoska wrote:
> ---
> daemon/libvirtd.h | 2 +
> daemon/remote.c | 207 ++++++++++++++++++++++++++++++++++++++++++-
> src/remote/remote_driver.c | 128 ++++++++++++++++++++++++++
> src/remote/remote_protocol.x | 43 ++++++++-
> src/remote_protocol-structs | 19 ++++
> 5 files changed, 395 insertions(+), 4 deletions(-)
> diff --git a/daemon/libvirtd.h b/daemon/libvirtd.h
> index 7271b0f..cc91266 100644
> --- a/daemon/libvirtd.h
> +++ b/daemon/libvirtd.h
> @@ -208,7 +234,6 @@ remoteRelayDomainQemuMonitorEventCheckACL(virNetServerClientPtr client,
> return ret;
> }
>
> -
> static int
> remoteRelayDomainEventLifecycle(virConnectPtr conn,
> virDomainPtr dom,
Dropped this spurious change
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index f494cbf..62deecd 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -7908,6 +8034,8 @@ static virStorageDriver storage_driver = {
> .connectListDefinedStoragePools = remoteConnectListDefinedStoragePools, /* 0.4.1 */
> .connectListAllStoragePools = remoteConnectListAllStoragePools, /* 0.10.2 */
> .connectFindStoragePoolSources = remoteConnectFindStoragePoolSources, /* 0.4.5 */
> + .connectStoragePoolEventDeregisterAny = remoteConnectStoragePoolEventDeregisterAny, /* 1.3.6 */
> + .connectStoragePoolEventRegisterAny = remoteConnectStoragePoolEventRegisterAny, /* 1.3.6 */
> .storagePoolLookupByName = remoteStoragePoolLookupByName, /* 0.4.1 */
> .storagePoolLookupByUUID = remoteStoragePoolLookupByUUID, /* 0.4.1 */
> .storagePoolLookupByVolume = remoteStoragePoolLookupByVolume, /* 0.4.1 */
Switched this reference to 2.0.0
> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index fe1b8a8..2d7299d 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -2551,6 +2551,22 @@ struct remote_network_event_lifecycle_msg {
> int event;
> int detail;
> };
> +struct remote_connect_storage_pool_event_register_any_args {
> + int eventID;
> + remote_storage_pool pool;
> +};
> +struct remote_connect_storage_pool_event_register_any_ret {
> + int callbackID;
> +};
> +struct remote_connect_storage_pool_event_deregister_any_args {
> + int callbackID;
> +};
> +struct remote_storage_pool_event_lifecycle_msg {
> + int callbackID;
> + remote_nonnull_storage_pool pool;
> + int event;
> + int detail;
> +};
> struct remote_domain_fsfreeze_args {
> remote_nonnull_domain dom;
> struct {
> @@ -3103,4 +3119,7 @@ enum remote_procedure {
> REMOTE_PROC_DOMAIN_GET_PERF_EVENTS = 365,
> REMOTE_PROC_DOMAIN_SET_PERF_EVENTS = 366,
> REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVAL_FAILED = 367,
> + REMOTE_PROC_CONNECT_STORAGE_POOL_EVENT_REGISTER_ANY = 368,
> + REMOTE_PROC_CONNECT_STORAGE_POOL_EVENT_DEREGISTER_ANY = 369,
> + REMOTE_PROC_STORAGE_POOL_EVENT_LIFECYCLE = 370,
> };
>
I installed latest pdwtags so I can actually run the protocol-structs test,
and it was still missing this diff, which is squashed in now:
diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
index 2d7299d..3934e07 100644
--- a/src/remote_protocol-structs
+++ b/src/remote_protocol-structs
@@ -2552,20 +2552,20 @@ struct remote_network_event_lifecycle_msg {
int detail;
};
struct remote_connect_storage_pool_event_register_any_args {
- int eventID;
- remote_storage_pool pool;
+ int eventID;
+ remote_storage_pool pool;
};
struct remote_connect_storage_pool_event_register_any_ret {
- int callbackID;
+ int callbackID;
};
struct remote_connect_storage_pool_event_deregister_any_args {
- int callbackID;
+ int callbackID;git
};
struct remote_storage_pool_event_lifecycle_msg {
- int callbackID;
- remote_nonnull_storage_pool pool;
- int event;
- int detail;
+ int callbackID;
+ remote_nonnull_storage_pool pool;
+ int event;
+ int detail;
};
Thanks,
Cole
More information about the libvir-list
mailing list