[libvirt] [PATCH] util: fix missing broadcast address in bridge and tap device IP addresses

[Laine Stump]

On 06/16/2016 02:24 PM, John Ferlan wrote:
>
> On 06/16/2016 01:29 PM, Laine Stump wrote:
>> Commit b3d069872ce53eb added peer address setting to the low level
>> virNetDevSetIPAddress() function, but ended up causing a segfault in
>> cases where the caller passed NULL for peer address.
>>
>> Commit a3510e33d33e52c fixed the segfault, but managed to cause us to
>> skip setting the broadcast address when setting an interface's IP
>> address if the peer address was NULL. The result is that the broadcast
>> address is 0.0.0.0 for all libvirt-created bridges (and for now also
>> in interfaces in lxc containers with IP addresses set by libvirt).
>>
>> This was reported on the mailing list:
>>
>>    https://www.redhat.com/archives/libvir-list/2016-June/msg00027.html
>>
>> but I was too busy to investigate at the time. I found it by accident
>> today while refactoring virNetDevSetIPAddress(). Since this regression
>> is present in the 1.3.5 release, I'm sending the bugfix as a separate
>> simpler patch from my larger refactoring patchset.
>> ---
>>
>>   src/util/virnetdev.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
> ACK

Thanks! I pushed it.