[libvirt] [PATCH 4/6] Remove virsh-synopsis

Ján Tomko jtomko at redhat.com
Fri Jun 17 18:04:39 UTC 2016


This tests checks that the first word after SYNOPSIS
in virsh help ${command} output is ${command}.

This was only good to check that the command option structures
are valid, which is now served by 'virsh self-test'.
---
 tests/Makefile.am    |  1 -
 tests/virsh-synopsis | 44 --------------------------------------------
 2 files changed, 45 deletions(-)
 delete mode 100755 tests/virsh-synopsis

diff --git a/tests/Makefile.am b/tests/Makefile.am
index b09526a..3ec7e7a 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -370,7 +370,6 @@ libvirtd_test_scripts =		\
 	virsh-schedinfo			\
 	virsh-self-test				\
 	virsh-start			\
-	virsh-synopsis			\
 	virsh-undefine			\
 	virsh-uriprecedence		\
 	virsh-vcpupin			\
diff --git a/tests/virsh-synopsis b/tests/virsh-synopsis
deleted file mode 100755
index d0d1197..0000000
--- a/tests/virsh-synopsis
+++ /dev/null
@@ -1,44 +0,0 @@
-#!/bin/sh
-# ensure that each command's help "SYNOPSIS" line starts with the command name
-
-# Copyright (C) 2008 Red Hat, Inc.
-
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 2 of the License, or
-# (at your option) any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see
-# <http://www.gnu.org/licenses/>.
-
-. "$(dirname $0)/test-lib.sh"
-
-if test "$VERBOSE" = yes; then
-  set -x
-  $abs_top_builddir/tools/virsh --version
-fi
-
-fail=0
-
-test_url=test:///default
-
-$abs_top_builddir/tools/virsh -c $test_url help > cmds || framework_failure
-cmds=$(sed -n 's/^    \([^ ][^ ]*\) .*/\1/p' cmds) || framework_failure
-test -n "$cmds" || framework_failure
-
-for i in $cmds; do
-    $abs_top_builddir/tools/virsh -c $test_url help $i > help || fail=1
-    grep -A1 '^  SYNOPSIS$' help > synopsis \
-      || { echo 1>&2 missing or invalid help SYNOPSIS for $i; fail=1; }
-    sed -n 2p synopsis > s2 || framework_failure
-    grep -E "^    $i( |$)" s2 > /dev/null \
-      || { echo 1>&2 "invalid help SYNOPSIS for $i:"; cat s2 1>&2; fail=1; }
-done
-
-(exit $fail); exit $fail
-- 
2.7.3




More information about the libvir-list mailing list