[libvirt] [PATCH 1/6] Remove virsh-all

[Peter Krempa]

On Fri, Jun 17, 2016 at 20:04:36 +0200, Ján Tomko wrote:
> Since e8ac4a7 this test wastes some CPU cycles by blindly trying to
> run almost every virsh command, blindly throwing away the output
> and the return value and returning success if 'virsh help' successfully
> returned at least one command.
> 
> Drop it completely.
> ---
>  tests/Makefile.am |  1 -
>  tests/virsh-all   | 52 ----------------------------------------------------
>  2 files changed, 53 deletions(-)
>  delete mode 100755 tests/virsh-all

[...]

> diff --git a/tests/virsh-all b/tests/virsh-all
> deleted file mode 100755
> index 4a91e4e..0000000
> --- a/tests/virsh-all
> +++ /dev/null
> @@ -1,52 +0,0 @@


> -counter=0
> -for i in $cmds; do
> -    counter=`eval "expr $counter + 1"`
> -
> -    # For now, just run the command and ignore output
> -    $abs_top_builddir/tools/virsh -c $test_url $i < /dev/null > /dev/null 2>&1
> -    # Temporarily ignoring exit status
> -    #status=$?
> -    status=0

Lol!

> -    test_result $counter $i $status

ACK