[libvirt] [PATCH 08/11] qemu: Introduce qemuMigrationSetParams

[Ján Tomko]

On Tue, Jun 21, 2016 at 01:47:14PM +0200, Jiri Denemark wrote:
>Several places in the code update qemuMonitorMigrationParams structure
>and qemuMigrationSetParams is then used to set them all at once.
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> src/qemu/qemu_migration.c | 59 ++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 46 insertions(+), 13 deletions(-)
>

>@@ -3455,17 +3455,14 @@ qemuMigrationSetCompression(virQEMUDriverPtr driver,
>     if (qemuDomainObjEnterMonitorAsync(driver, vm, job) < 0)
>         return -1;
>
>-    migParams.compressLevel_set = compression->level_set;
>-    migParams.compressLevel = compression->level;
>+    migParams->compressLevel_set = compression->level_set;
>+    migParams->compressLevel = compression->level;
>
>-    migParams.compressThreads_set = compression->threads_set;
>-    migParams.compressThreads = compression->threads;
>+    migParams->compressThreads_set = compression->threads_set;
>+    migParams->compressThreads = compression->threads;
>
>-    migParams.decompressThreads_set = compression->dthreads_set;
>-    migParams.decompressThreads = compression->dthreads;
>-
>-    if (qemuMonitorSetMigrationParams(priv->mon, &migParams) < 0)
>-        goto cleanup;
>+    migParams->decompressThreads_set = compression->dthreads_set;
>+    migParams->decompressThreads = compression->dthreads;
>

This would look nicer in a separate function.

ACK regardless.

Jan