[libvirt] [PATCH 18/28] qemu: forbid setting guest-side IP address/route info of <interface>

[John Ferlan]

On 06/22/2016 01:37 PM, Laine Stump wrote:
> libvirt's qemu driver doesn't have direct access to the config on the
> guest side of a network interface, and currently doesn't have any
> method in place to even inform the guest of the desired config. In the
> future, an unenforceable attempt to set the guest-side IP info could
> be made by adding a static host entry to the appropriate dnsmasq
> configuration (or changing the default dhcp client address on the qemu
> commandline for type='user' interfaces), or enhancing the guest agent
> to allow setting an IP address, but for now it can't have any effect,
> and we don't want to give the illusion that it does.
> 
> To prevent the "disappearance" of any existing configs with ip
> address/route info (due to parser failure), this check is added in the
> newly implemented qemuDomainDeviceDefValidate(), which is only called
> when a domain is defined or started, *not* when it is reread from disk
> at libvirtd startup.
> ---
>  src/qemu/qemu_domain.c | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 

ACK

John