[libvirt] [PATCH 3/4] Check for VFIO too where the Legacy passthrough is checked
Andrea Bolognani
abologna at redhat.com
Fri Jun 24 13:09:38 UTC 2016
On Wed, 2016-06-22 at 16:37 +0200, Andrea Bolognani wrote:
> On Wed, 2016-06-15 at 09:57 +0000, Shivaprasad G Bhat wrote:
> > On PPC the Legacy patthrough is not supported and only
>
> s/patthrough/passthrough/
>
> > VFIO is supported. So, the checks at places to confirm if the
> > host is passthrough capable checks only Legacy, fix it. This
> > is seen at only one place now.
> >
> > Signed-off-by: Shivaprasad G Bhat <sbhat at linux.vnet.ibm.com>
> > ---
> > src/qemu/qemu_driver.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> > index 65ef68c..6b316a0 100644
> > --- a/src/qemu/qemu_driver.c
> > +++ b/src/qemu/qemu_driver.c
> > @@ -18413,7 +18413,8 @@ qemuConnectGetDomainCapabilities(virConnectPtr conn,
> >
> > cfg = virQEMUDriverGetConfig(driver);
> >
> > - if (qemuHostdevHostSupportsPassthroughLegacy())
> > + if (qemuHostdevHostSupportsPassthroughLegacy() ||
> > + qemuHostdevHostSupportsPassthroughVFIO())
> > virttype = VIR_DOMAIN_VIRT_KVM;
> > else
> > virttype = VIR_DOMAIN_VIRT_QEMU;
>
> This looks like an unrelated bugfix. If that's the case,
> please yank it out of the series and submit it separately.
>
> Looks good otherwise :)
Since you've confirmed (on IRC) that this is indeed an
independed bugfix, and the patch is already good to go,
I've amended the commit messages and pushed it.
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list