[libvirt] [PATCH] conf: Allocate structure for 'perf' events in virDomainDefNew

Ján Tomko jtomko at redhat.com
Wed Jun 29 06:07:29 UTC 2016


On Tue, Jun 28, 2016 at 02:43:59PM +0200, Peter Krempa wrote:
>Some code paths already assume that it is allocated since it was always
>allocated by virDomainPerfDefParseXML. Move allocation to

Shouldn't we rather fix those code paths?

virDomainDefNew would get ridiculously long if we started assuming this
for every optional XML element.

Jan

>virDomainDefNew to handle cases that don't go through the XML parser.
>
>This fixes crash when attempting to connect to an existing process via
>virDomainQemuAttach.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1350688
>---
> src/conf/domain_conf.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>




More information about the libvir-list mailing list