[libvirt] [PATCH v2] conf: def: Avoid unnecessary allocation of 'perf' events definition

Ján Tomko jtomko at redhat.com
Thu Jun 30 12:53:01 UTC 2016


On Thu, Jun 30, 2016 at 09:45:05AM +0200, Peter Krempa wrote:
>Some code paths already assume that it is allocated since it was always
>allocated by virDomainPerfDefParseXML. Make it member of virDomainDef
>directly so that we don't have to allocate it all the time.
>
>This fixes crash when attempting to connect to an existing process via
>virDomainQemuAttach since we would not allocate it in that code path.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1350688
>---
> src/conf/domain_conf.c  | 12 ++----------
> src/conf/domain_conf.h  |  2 +-
> src/qemu/qemu_driver.c  |  6 +++---
> src/qemu/qemu_process.c |  8 ++++----
> 4 files changed, 10 insertions(+), 18 deletions(-)
>

ACK

Jan




More information about the libvir-list mailing list