[libvirt] [PATCH 6/7] virNetworkDefForwardIf: drop inline

Martin Kletzander mkletzan at redhat.com
Thu Mar 3 11:01:31 UTC 2016


On Thu, Mar 03, 2016 at 09:44:41AM +0100, Michal Privoznik wrote:
>In file included from network/bridge_driver_platform.h:30:0,
>                 from network/bridge_driver_platform.c:26:
>network/bridge_driver_linux.c: In function 'networkRemoveRoutingFirewallRules':
>./conf/network_conf.h:350:1: error: inlining failed in call to 'virNetworkDefForwardIf.constprop': call is unlikely and code size would grow [-Werror=inline]
> virNetworkDefForwardIf(const virNetworkDef *def, size_t n)
> ^
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Double sign-off;

not only drop inline, but make it as non-static function.  To those that
might wonder why isn't only the static keyword removed, that doesn't
work, I tried it, but I cannot explain it.  This is the same patch I
came up with, except the double sign-off ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160303/05dab4cf/attachment-0001.sig>


More information about the libvir-list mailing list