[libvirt] [PATCH] qemu: Check if domain is active in GetControlInfo
Erik Skultety
eskultet at redhat.com
Thu Mar 3 12:53:00 UTC 2016
On 03/03/16 13:43, Jiri Denemark wrote:
> Reporting status of a control connection makes no sense for an inactive
> domain.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1281706
>
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
> src/qemu/qemu_driver.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 4bd4071..9fd4c57 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -2763,6 +2763,12 @@ qemuDomainGetControlInfo(virDomainPtr dom,
> if (virDomainGetControlInfoEnsureACL(dom->conn, vm->def) < 0)
> goto cleanup;
>
> + if (!virDomainObjIsActive(vm)) {
> + virReportError(VIR_ERR_OPERATION_INVALID, "%s",
> + _("domain is not running"));
> + goto cleanup;
> + }
> +
> priv = vm->privateData;
>
> memset(info, 0, sizeof(*info));
>
ACK
Erik
More information about the libvir-list
mailing list