[libvirt] [PATCH] virLXCProcessMonitorInitNotify: Initialize @inode

Michal Privoznik mprivozn at redhat.com
Fri Mar 4 14:23:50 UTC 2016


This is an error message I've just seen. Fix it by initializing
@inode.

  CC       lxc/libvirt_driver_lxc_impl_la-lxc_process.lo
lxc/lxc_process.c: In function 'virLXCProcessMonitorInitNotify':
lxc/lxc_process.c:767:23: error: 'inode' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     virDomainAuditInit(vm, initpid, inode);
                       ^

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---

Pushed under trivial rule.

 src/lxc/lxc_process.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index 50bee48..5e0bbe2 100644
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -749,7 +749,7 @@ static void virLXCProcessMonitorInitNotify(virLXCMonitorPtr mon ATTRIBUTE_UNUSED
     virLXCDriverPtr driver = lxc_driver;
     virLXCDomainObjPrivatePtr priv;
     virLXCDriverConfigPtr cfg = virLXCDriverGetConfig(driver);
-    ino_t inode;
+    ino_t inode = 0;
 
     virObjectLock(vm);
 
@@ -762,7 +762,6 @@ static void virLXCProcessMonitorInitNotify(virLXCMonitorPtr mon ATTRIBUTE_UNUSED
                  (unsigned long long)initpid,
                  err && err->message ? err->message : "<unknown>");
         virResetLastError();
-        inode = 0;
     }
     virDomainAuditInit(vm, initpid, inode);
 
-- 
2.4.10




More information about the libvir-list mailing list