[libvirt] [PATCH REPOST 5/9] qemu: Introduce qemuBuildControllerDevCommandLine
Cole Robinson
crobinso at redhat.com
Thu Mar 10 23:07:09 UTC 2016
On 03/08/2016 02:03 PM, John Ferlan wrote:
> Add new function to manage adding the controller -device options to the
> command line removing that task from the mainline qemuBuildCommandLine.
>
> Also adjust to using const virDomainDef instead of virDomainDefPtr.
> This causes collateral damage in order to modify called APIs to use
> the const virDomainDef instead as well.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> src/conf/domain_conf.c | 10 +-
> src/conf/domain_conf.h | 4 +-
> src/qemu/qemu_command.c | 224 ++++++++++++++++++++++-------------------
> src/qemu/qemu_command.h | 4 +-
> src/qemu/qemu_domain_address.c | 2 +-
> src/qemu/qemu_domain_address.h | 2 +-
> 6 files changed, 132 insertions(+), 114 deletions(-)
>
The check_add_usb: bit isn't really needed since the !QEMU_CAPS_DEVICE bit
will never be triggered nowadays... but that's a larger cleanup that it isn't
worth mixing up with these reworks
ACK
- Cole
More information about the libvir-list
mailing list