[libvirt] [PATCH] qemuBuildVideoCommandLine: Don't access def->videos without check

Peter Krempa pkrempa at redhat.com
Mon Mar 14 09:19:18 UTC 2016


On Mon, Mar 14, 2016 at 09:47:05 +0100, Michal Privoznik wrote:
> This function can be called over a domain definition that has no
> video configured. The
> tests/qemuxml2argvdata/qemuxml2argv-minimal.xml file could serve
> as an example. Problem is, before the check that domain has some
> or none video configured, def->videos is dereferenced causing a
> segmentation fault in case there's none video configured.

Caused by commit 95ca4fe2

> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_command.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

ACK

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160314/34216ea3/attachment-0001.sig>


More information about the libvir-list mailing list