[libvirt] [PATCH] qemu: Don't overwrite DomainSave errors

Cole Robinson crobinso at redhat.com
Tue Mar 15 19:24:44 UTC 2016


These functions already report fine grained errors, there's no
benefit to overwriting the error here.
---
 src/qemu/qemu_driver.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index edf39d9..36c8fb5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17632,8 +17632,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
 
         ret = virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps);
         if (ret < 0) {
-            virReportError(VIR_ERR_OPERATION_FAILED, "%s",
-                           _("Saving live XML config failed"));
             goto endjob;
         }
 
@@ -17659,8 +17657,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
         conf_disk->blkdeviotune = info;
         ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef);
         if (ret < 0) {
-            virReportError(VIR_ERR_OPERATION_INVALID, "%s",
-                           _("Write to config file failed"));
             goto endjob;
         }
     }
-- 
2.5.0




More information about the libvir-list mailing list