[libvirt] [PATCH] storage: revert bogus raw volumes support check
Roman Bogorodskiy
bogorodskiy at gmail.com
Sun Mar 27 18:09:11 UTC 2016
John Ferlan wrote:
>
>
> On 03/26/2016 01:10 PM, Roman Bogorodskiy wrote:
> > Commits bb5f2dc and 6682d62 added a check like:
> >
> > if (vol->target.format != VIR_STORAGE_FILE_RAW)
> >
> > to the CreateVol method for zfs and logical storage backends
> > respectively. However, this check is bogus because
> > virStorageVolDefParseXML() in conf/storage_conf.c sets target.format
> > only if volOptions in virStoragePoolTypeInfo has formatFromString set,
> > and that's not the case for zfs and logical backends. So the check
> > always fails and breaks volume creation.
> >
> > Thus, revert those commits.
> > ---
> > src/storage/storage_backend_logical.c | 6 ------
> > src/storage/storage_backend_zfs.c | 6 ------
> > 2 files changed, 12 deletions(-)
> >
>
> ACK - although I redid it slightly to use the git revert command and
> adjusting the commit ...
Great, thanks!
I used git revert as well, but then decided that I'm lazy to write
almost the same commit message twice and squashed that into one.
Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160327/a315e662/attachment-0001.sig>
More information about the libvir-list
mailing list