[libvirt] [PATCH] admin_server: fix memory leak

Pavel Hrdina phrdina at redhat.com
Tue Mar 29 13:31:15 UTC 2016


If caller of adminConnectListServers() pass NULL instead of servers we
need to free the list we've received from virNetDaemonGetServers().

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 daemon/admin_server.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/daemon/admin_server.c b/daemon/admin_server.c
index 1d16bc9..2f26488 100644
--- a/daemon/admin_server.c
+++ b/daemon/admin_server.c
@@ -52,6 +52,8 @@ adminConnectListServers(virNetDaemonPtr dmn,
     if (servers) {
         *servers = srvs;
         srvs = NULL;
+    } else {
+        virObjectListFreeCount(srvs, ret);
     }
  cleanup:
     return ret;
-- 
2.7.4




More information about the libvir-list mailing list